feat: add display_tempo property to Meter class #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds display_tempo property to convert between internal pulse tempo and performance practice tempo (at matra/beat level). In Hindustani music, musicians think of tempo at layer 1, but the internal representation stores tempo at the finest pulse level. New methods: - display_tempo (property getter/setter): Get/set tempo at matra level - get_tempo_at_layer(layer): Get tempo at any specific hierarchy layer - _get_hierarchy_mult(layer): Helper to get multiplier for a layer Closes #55 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
|
📦 Test Package Built Successfully! This PR has been automatically built and uploaded to TestPyPI for testing. 🔗 TestPyPI Link: https://test.pypi.org/project/idtap/ To test this version: pip install --index-url https://test.pypi.org/simple/ idtap✅ All tests passed and package builds successfully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
display_tempoproperty to convert between internal pulse tempo and performance practice tempo (at matra/beat level)[[4,4,4,4], 4](Tintal) with internal tempo 60 BPM, display tempo = 60 × 4 = 240 BPMNew Methods
display_tempo(property getter/setter): Get/set tempo at matra levelget_tempo_at_layer(layer): Get tempo at any specific hierarchy layer_get_hierarchy_mult(layer): Private helper to get multiplier for a layerTest plan
Closes #55
🤖 Generated with Claude Code